Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't assert when calculating log2 of non-power-of-two number, fail instead. #192

Merged
merged 3 commits into from
May 28, 2024
Merged

fix: don't assert when calculating log2 of non-power-of-two number, fail instead. #192

merged 3 commits into from
May 28, 2024

Conversation

ttjost
Copy link

@ttjost ttjost commented May 28, 2024

No description provided.

@ttjost ttjost requested a review from cmcgirr-amd May 28, 2024 13:06
cmcgirr-amd
cmcgirr-amd approved these changes May 28, 2024
View reviewed changes
Copy link

@cmcgirr-amd cmcgirr-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ttjost ttjost enabled auto-merge May 28, 2024 15:13
@ttjost ttjost merged commit 25a21e0 into feature/fused-ops May 28, 2024
3 checks passed
@ttjost ttjost deleted the tiagot.dont_assert_log2_inexact branch May 28, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcgirr-amd cmcgirr-amd cmcgirr-amd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttjost @cmcgirr-amd