Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute conversion lowering to EmitC #431

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

TinaAMD
Copy link

@TinaAMD TinaAMD commented Dec 20, 2024

When lowering constants, it might be necessary to not only convert the type, but the attribute as well. Introduce this lowering for arith constants and memref globals.

@TinaAMD TinaAMD marked this pull request as ready for review January 3, 2025 10:07
Copy link
Collaborator

@josel-amd josel-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cferry-AMD cferry-AMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TinaAMD TinaAMD merged commit db08afe into feature/fused-ops Jan 6, 2025
6 checks passed
@TinaAMD TinaAMD deleted the tina.add-attribute-conversion branch January 6, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants