Cherry-pick upstream CI changes #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#117353) Also switch them over to the new depot runners.
Bump the CI container version to the latest release.
This patch adds a windows CI container mostly based off of the existing container used for Buildkite (https://github.com/google/llvm-premerge-checks/blob/a687e33c37fbdcf67b52805c8cf3a8ed145e3243/containers/buildkite-windows/Dockerfile#L1). This is intended to be a starting point as we transition to Github Actions with the eventual plan being to build a custom windows toolchain similar to what we do on Linux.
This patch adds some additional system packages to the CI container. These are necessary for use in the new premerge workflows. The size increase is not super small, but should be manageable with the size increase being about 100MB.
This patch sets the default user in the linux CI container to a non-root user, which enables properly testing a couple of features, particularly in libcxx.
mgehre-amd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick upstream changes related to the docker container used in CI.
We use the docker image from upstream (
ghcr.io/llvm/ci-ubuntu-22.04:latest), which changed recently.We need to bring the corresponding changes of the CI flows to be able to work with the new containter.