Enable lowering all float types to tosa #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josel-amd
commented
May 8, 2024
josel-amd
force-pushed
the
jose.enable_float8
branch
from
3f16f17 to
cafc2e0
Compare
mgehre-amd
reviewed
May 8, 2024
mgehre-amd
reviewed
May 8, 2024
mgehre-amd
reviewed
May 8, 2024
mgehre-amd
reviewed
May 8, 2024
mgehre-amd
reviewed
May 8, 2024
Float8 types start to be supported from V21.
TinaAMD
changed the title
mgehre-amd
approved these changes
May 10, 2024
|
Thanks, looks good! |
TinaAMD
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow lowering of all floating point types available in onnx-mlir to tosa, since tosa now allows arbitrary floating point types when no specific mode is used (see Xilinx/llvm-project#175).