Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lowering all float types to tosa #85

Merged
merged 20 commits into from
May 13, 2024

Conversation

josel-amd
Copy link
Collaborator

@josel-amd josel-amd commented May 8, 2024

Allow lowering of all floating point types available in onnx-mlir to tosa, since tosa now allows arbitrary floating point types when no specific mode is used (see Xilinx/llvm-project#175).

@josel-amd josel-amd requested review from mgehre-amd and TinaAMD May 8, 2024 10:06
@josel-amd josel-amd force-pushed the jose.enable_float8 branch from 3f16f17 to cafc2e0 Compare May 8, 2024 12:39
@TinaAMD TinaAMD changed the title Enable float8 when converting to tosa Enable lowering all float types to tosa May 10, 2024
@TinaAMD TinaAMD requested a review from mgehre-amd May 10, 2024 14:13
@mgehre-amd
Copy link
Collaborator

Thanks, looks good!

@mgehre-amd mgehre-amd enabled auto-merge May 13, 2024 07:25
@mgehre-amd mgehre-amd merged commit e6720d7 into feature/onnx-to-tosa May 13, 2024
5 checks passed
@mgehre-amd mgehre-amd deleted the jose.enable_float8 branch May 13, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants