楊鎧睿 html-css-practice #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xinhe998
reviewed
Dec 30, 2017
Owner
Xinhe998
left a comment
Xinhe998
left a comment
There was a problem hiding this comment.
棒棒～網頁配色很好看，每個commit也很嚴謹，繼續加油！
css/style.css
Outdated
| } | ||
|
|
||
| ul { | ||
| display: inline-block; |
Owner
There was a problem hiding this comment.
這裡的 display:inline-block; 應該移到ul li中～
css/style.css
Outdated
|
|
||
| ul li { | ||
| list-style-type: none; | ||
| float: left; |
Owner
There was a problem hiding this comment.
這裡不需要用到float哦！把 display: inline-block 移到這就可以了
css/style.css
Outdated
| background-color: #b7ac71; | ||
| color: black; | ||
| border: 0px; | ||
| border-radius: 10px; |
Owner
There was a problem hiding this comment.
:hover 會繼承原樣式，所以一樣的樣式就不需要重複設定囉～
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.