Fix display issues with broken border or characters from the previous line not being cleared #532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to find the reason why sometimes the borders get broken, or we have a character from a line that still gets displayed. This is the same issue as #298 (comment).
I think this only happened on kitty, and maybe foot, because this came from the fact that ratatui and most other terminals were calculating the width of the
\u{e0000}
character incorrectly.This character is used by twitch clients like chatterino to bypass twitch duplicate message timeout, so it can appear quite frequently.
My fix is to just remove it from the message as it is not meant to be rendered.
It is possible that there are some other discrepancies between ratatui and different terminals, so there could be some other unicode characters that will display the same rendering issues, but I haven't seen any for now.
This PR is independent of the other 2 I have, so you can merge it whenever you want.