Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Literal Input Fixes #295

Merged
merged 4 commits into from
Feb 19, 2024
Merged

🐛 Literal Input Fixes #295

merged 4 commits into from
Feb 19, 2024

Conversation

MFA-X-AI
Copy link
Member

Description

This PR fixes the following bugs:

  • fix floats to allow scientific notation
  • fix floats to allow non-decimal inputs
  • fix boolean dragging from ports to be always true
  • fix literal chat being unable to carriage return on enter

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Verify that:

  1. You can input scientific notation and non-decimal inputs on floats (also on integers)
  2. When you create a literal bool from a port, it will correctly display True or False
  3. You can carriage return on a literal chat interface

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/fix-lit-input

@MFA-X-AI MFA-X-AI merged commit f0688c9 into master Feb 19, 2024
@MFA-X-AI MFA-X-AI deleted the fahreza/fix-lit-input branch February 19, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant