Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Initialize Base Canvas For New Xircuits #300

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

MFA-X-AI
Copy link
Member

Description

This PR updates the create a new xircuits function to initializes a base xircuits json first, then writes it to the new file, then finally opening it.

References

If applicable, note issue numbers this pull request addresses. You can also note any other pull requests that address this issue and how this pull request is different.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Previously for new canvas, after dropping the first node, the second would not appear until you save the canvas. With this PR, it should function properly.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Add if any.

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/init-new-canvas

@MFA-X-AI MFA-X-AI merged commit 285cd74 into master Feb 23, 2024
9 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/init-new-canvas branch July 8, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant