Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #384 we've added the support for structured logging. This logging requires that each component has a well defined id.
We assumed that just defining this on
BaseComponent
as a constructor parameter would be enough to get the rudimentary support going. But it turns out that Components with custom constructors didn't like being instantiated with the id in the call parameters.In particular the Workflow Components that the compiler creates didn't support it. But there are also a couple of other components that have the same issue.
This PR fixes the compiler to emit Workflow Components that will accept an id as a constructor parameter, but also moves the id assignment to be done with an additional property based call.
Ideally, we want to move the id assignment back to the component constructor, but until every component library had a chance to be updated, we will keep this more compatible way of doing it.
Pull Request Type
Type of Change