-
Notifications
You must be signed in to change notification settings - Fork 15
WIP: Replace docstring bubble with right sidebar preview #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
What’s new in this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This is a big feature, so here's a longer review:
- The sidebar preview has quite a large minimum sized window. I think it should follow the minimum width as the other sidebars.
sidebar.width.mp4
- The previous and next node logic shouldn't go to Literals and Arguments.
sidebar.previous.and.next.mp4
I think you should allow it to go to Start and Finish and display a simple message like, "This is the start or end of your workflow!"
- The component preview doesn't switch context when another canvas is active. I think it should just reset once a new workflow is opened.
canvas.active.mp4
-
This does mean it might be complex if there is 2 active workflows for whatever reason. If that's the case, you might need to display on the component preview which component is this workflow coming from. I think that's a good thing to have anyways. Maybe under the Component preview header.
-
I think we can improve the current preview for blank canvas. I'll pass you a placeholder image.

- workflow components doesn't seem to have an
i
button yet. I guess that's something we haven't added.

Since this is a info docstring PR, could you add it in?
- The handling for the previous and next node for branch component might be a bit more complex. I think the best way is go to the top paths only.
branch.handling.mp4
okay, that's some things to do for now. Thanks a bunch.
Final Changes Implemented Based on Review Feedback: Sidebar Width
Previous/Next Navigation
Canvas Switching
Workflow Components
|
Description
Pull Request Type
Type of Change
Tests
Launch Binder (or run locally).
Drag any component into the canvas.
Click the ℹ︎ icon on the node.
Click the same ℹ︎ again → the sidebar collapses.
Click ℹ︎ on a different component → the sidebar swaps to the new docstring.
Tested on? Specify Version.