Skip to content

Exercise 8 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Exercise 8 #7

wants to merge 44 commits into from

Conversation

@rudri182
Copy link

@rudri182 rudri182 commented Dec 19, 2017

Exercise 8
8.3 and 8.4 done successfully.
some compiled time error in 8.5

@rudri182 rudri182 requested a review from YJDave as a code owner December 19, 2017 14:22
YJDave
YJDave reviewed Dec 19, 2017
View reviewed changes
Copy link
Owner

@YJDave YJDave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @rudri182 this is looking nice. Some points to improve it.

  • can you change commit message to 8: Solution for 8.x exercise
  • Squash commits into one commit per one exercise

@rudri182 rudri182 closed this Dec 22, 2017
@rudri182 rudri182 reopened this Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YJDave YJDave YJDave left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rudri182 @YJDave