Skip to content

increase distance threshold to ignore culling #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NodokaHanamura merged 1 commit into from
Jun 16, 2025
Merged

increase distance threshold to ignore culling #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/core/fssimulation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7188,8 +7188,6 @@ void FsSimulation::SimDrawAirplane(const ActualViewMode &actualViewMode,const Fs
//FOV and screen size (pixels) check for draw culling purposes
bool FsSimulation::IsObjectVisible(FsExistence* obj, const ActualViewMode& actualViewMode, const FsProjection& proj) const
{
std::string id = obj->CommonProp().GetIdentifier();

//calculate object position in player's view
YsVec3 objPosInCamSpace = actualViewMode.viewMat * obj->GetPosition();

Expand All @@ -7198,17 +7196,17 @@ bool FsSimulation::IsObjectVisible(FsExistence* obj, const ActualViewMode& actua
obj->vis.GetBoundingBox(boxMin, boxMax);

//calculate span of bounding box
double boundingBoxDiag = 1.0 * ((boxMin - boxMax).GetLength());
double boundingBoxDiag = ((boxMin - boxMax).GetLength());

//distance from object to camera (magnitude of obj position vector in camera space)
double objDistToCam = objPosInCamSpace.GetLength();

//compute obj size on screen
double apparentRadInPixels = boundingBoxDiag * proj.prjPlnDist / objDistToCam;

//if object is within bounding box span length of cam, draw it regardless of viewport visibility
//if object is within 2x bounding box span length of cam, draw it regardless of viewport visibility
//(angular culling method below sometimes fails for extreme angles at close distances to camera)
if (objDistToCam < boundingBoxDiag)
if (objDistToCam < 2.0 * boundingBoxDiag)
{
return true;
}
Expand Down
Loading