-
-
Notifications
You must be signed in to change notification settings - Fork 629
Add per output BPC config #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Do we want to do this? Over just listing all formats always? |
|
I think this will mitigate the bandwidth issue you mentioned by limiting the max bpc (for some monitors), and also any potential driver/display issue where they advertise more than what they support. One change I will make is to set the default based on the "max dpc" that is reported from DRM. Nevertheless, I don't see any disadvantage for finer-grain control as done in the case of KWin and Mutter. |
|
I'm not sure if there is a bandwidth issue, just hypothesizing. If possible I'm for no config.
max bpc is something the compositor can change though?
What do they do? |
Sorry I meant from EDID. Though it might be easier to use the DRM set default if no bpc is give. From Mutter:
Though I think we also need to also set the |
|
A few changes:
EDIT: It means that by default, without any config, niri will use |
|
@YaLTeR should be ready for review 👍 |
This adds per output bits per colour (BPC) config as requested in #1533.
Supported values are 8, 10. If not explicitly set, niri will not change the existing
max bpcconnector property.