This repository was archived by the owner on Mar 22, 2023. It is now read-only.
Created new data source for Librato and updated example YAML config#88
Open
akhil-m wants to merge 6 commits intoYelpArchive:masterfrom
Open
Created new data source for Librato and updated example YAML config#88akhil-m wants to merge 6 commits intoYelpArchive:masterfrom
akhil-m wants to merge 6 commits intoYelpArchive:masterfrom
Conversation
firefly/data_sources/librato.py
Outdated
Contributor
There was a problem hiding this comment.
urllib2 and requests? pick one or the other.
also this requirement needs to be added to our requirements.txt
Contributor
There was a problem hiding this comment.
Do we need to add this to setup.py? or why not?
Contributor
There was a problem hiding this comment.
Would there be duplicated sources?
Author
There was a problem hiding this comment.
Within a particular metric? No.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.