This repository was archived by the owner on Feb 4, 2020. It is now read-only.
Addressing Issue #89 #90
Open
akondasif wants to merge 4 commits into
Open
Conversation
Replaced hard-coded password with hiera, and removed binding with 0.0.0.0.
default password needs to be replaced
Added hiera support for default password.
solarkennedy
suggested changes
Jul 18, 2018
| $port = 3000 | ||
| $user = '' | ||
| $pass = '' | ||
| $pass = hiera('default_pass') |
Contributor
There was a problem hiding this comment.
Don't bother with this direct hiera lookup. Just put 'needs_to_be_changed' if that is what you want to be the default.
Removing hiera stuff
| @@ -0,0 +1 @@ | |||
| default_pass: needs_to_be_changed | |||
Contributor
There was a problem hiding this comment.
Can you remove the hiera related files?
Contributor
There was a problem hiding this comment.
Just take care of this last issue and I'll merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have submitted a pull request to remove two smells mentioned in issue #89
Feedback welcome.