-
Notifications
You must be signed in to change notification settings - Fork 638
Feature/improve permission handling and management #6891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
redneck-f25
wants to merge
15
commits into
Ylianst:master
Choose a base branch
from
bitctrl:feature/improve-permission-handling-and-management
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/improve permission handling and management #6891
redneck-f25
wants to merge
15
commits into
Ylianst:master
from
bitctrl:feature/improve-permission-handling-and-management
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i think this PR needs splitting up as the is SO MUCH you have changed and is all confusing to following! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6890
Sorry this PR has a bunch of commits and changed files. While working on the main issue, I found some minor issues... :-)
Changes
"env": { "MESHCENTRAL_DEV_NO_AGENT_SIGNING": "1" }
to launch configuration)domains.ID.desktop.viewonly
applyFeaturePermissionsToRouterAndWebTools
novncargs
novncViewOnlyPort
const MESHRIGHT_HIDERDPSESSIONS = 0x00400000; // 4194304
features3
if (domain.applyfeaturepermissionstorouterandwebtools !== false) {features3 += 0x00000001; }
Dektop | Connect
ifMESHRIGHT_HIDERDPSESSIONS
is setMESHRIGHT_REMOTEVIEWONLY
Limited Input Only
to user featuresdefault{,3}.handlebars
Following the diff of the diffs against 88a765b