Skip to content

[ENH] bootstrap themes: Ensure h1 titles remain visible across light and dark themes #6950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ndaboom
Copy link
Contributor

@Ndaboom Ndaboom commented Apr 6, 2025

This fix sets explicit text colors for <h1> elements in both light and dark modes to ensure visibility and maintain visual contrast. A very dark gray (#adafae) is used for light mode to avoid pure black on white, improving readability and aesthetics, while a very light gray (#f8f9fa) is used in dark mode for optimal contrast.

@si458
Copy link
Collaborator

si458 commented Apr 8, 2025

this sadly hasnt really worked,
if you say use the darkly color scheme, and then switch your browser into light mode,
and check the my account page, the device groups are completely missing
image
but use dark mode for your browser and its perfectly fine
image

@Ndaboom
Copy link
Contributor Author

Ndaboom commented Apr 8, 2025

this sadly hasnt really worked, if you say use the darkly color scheme, and then switch your browser into light mode, and check the my account page, the device groups are completely missing image but use dark mode for your browser and its perfectly fine image

Oops, I tested with a MeshCentral instance without any device group(no devices data at all), which is why I couldn't see that part. I was only referring to the page titles to see if everything works. I will continue the work and push changes.
Thank you for the review.

@DaanSelen
Copy link
Contributor

this sadly hasnt really worked, if you say use the darkly color scheme, and then switch your browser into light mode, and check the my account page, the device groups are completely missing image but use dark mode for your browser and its perfectly fine image

Oops, I tested with a MeshCentral instance without any device group(no devices data at all), which is why I couldn't see that part. I was only referring to the page titles to see if everything works. I will continue the work and push changes. Thank you for the review.

Thank you for your time and effort in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants