fix: remove is_most_voted_id field and implement calculate_output met… #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod in AnonymousVotingCircuit
Workflow Telemetry - Rust CI / Run Groth16 BinaryWorkflow telemetry for commit a0d0d4f6478ea43e8c423a68a8c8d8f6d792512e Step Tracegantt
title Run Groth16 Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747824659000, 1747824661000
Collect Workflow Telemetry : 1747824661000, 1747824661000
Checkout code : 1747824661000, 1747824662000
Setup Rust : 1747824662000, 1747824672000
Cache dependencies : 1747824672000, 1747824673000
Run groth16 binary : 1747824673000, 1747824765000
Post Cache dependencies : 1747824765000, 1747824767000
Post Setup Rust : 1747824767000, 1747824772000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Online BinaryWorkflow telemetry for commit a0d0d4f6478ea43e8c423a68a8c8d8f6d792512e Step Tracegantt
title Run Online Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747824658000, 1747824661000
Collect Workflow Telemetry : 1747824661000, 1747824661000
Checkout code : 1747824661000, 1747824662000
Setup Rust : 1747824662000, 1747824673000
Cache dependencies : 1747824673000, 1747824673000
Copy input file : 1747824673000, 1747824673000
Preprocess inputs : 1747824673000, 1747824733000
Run online binary : 1747824733000, 1747824880000
Post Cache dependencies : 1747824880000, 1747824883000
Post Setup Rust : 1747824883000, 1747824890000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / TestsWorkflow telemetry for commit a0d0d4f6478ea43e8c423a68a8c8d8f6d792512e Step Tracegantt
title Tests
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747824659000, 1747824661000
Collect Workflow Telemetry : 1747824661000, 1747824662000
Checkout code : 1747824662000, 1747824663000
Setup Rust : 1747824663000, 1747824673000
Cache dependencies : 1747824673000, 1747824674000
Run tests : 1747824674000, 1747824889000
Post Cache dependencies : 1747824889000, 1747824891000
Post Setup Rust : 1747824891000, 1747824897000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Marlin BinaryWorkflow telemetry for commit a0d0d4f6478ea43e8c423a68a8c8d8f6d792512e Step Tracegantt
title Run Marlin Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747824658000, 1747824660000
Collect Workflow Telemetry : 1747824660000, 1747824661000
Checkout code : 1747824661000, 1747824661000
Setup Rust : 1747824661000, 1747824673000
Cache dependencies : 1747824673000, 1747824674000
Run marlin binary : 1747824674000, 1747825211000
Post Cache dependencies : 1747825211000, 1747825213000
Post Setup Rust : 1747825213000, 1747825219000
Post Checkout code : 1747825219000, 1747825219000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Werewolf BinaryWorkflow telemetry for commit a0d0d4f6478ea43e8c423a68a8c8d8f6d792512e Step Tracegantt
title Run Werewolf Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747824658000, 1747824661000
Collect Workflow Telemetry : 1747824661000, 1747824661000
Checkout code : 1747824661000, 1747824662000
Setup Rust : 1747824662000, 1747824673000
Cache dependencies : 1747824673000, 1747824673000
Run werewolf init : 1747824673000, 1747824787000
Run werewolf night : 1747824787000, 1747824814000
Run werewolf vote : 1747824814000, 1747824918000
Run werewolf judgment : 1747824918000, 1747825135000
Run werewolf role assignment : 1747825135000, 1747825368000
Post Cache dependencies : 1747825368000, 1747825371000
Post Setup Rust : 1747825371000, 1747825377000
Post Checkout code : 1747825377000, 1747825378000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Groth16 BinaryWorkflow telemetry for commit ffa32fa9e5a3d91132c4d93fe9362238459eb526 Step Tracegantt
title Run Groth16 Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747825747000, 1747825749000
Collect Workflow Telemetry : 1747825749000, 1747825749000
Checkout code : 1747825749000, 1747825750000
Setup Rust : 1747825750000, 1747825763000
Cache dependencies : 1747825763000, 1747825764000
Run groth16 binary : 1747825764000, 1747825808000
Post Cache dependencies : 1747825808000, 1747825808000
Post Setup Rust : 1747825808000, 1747825809000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Online BinaryWorkflow telemetry for commit ffa32fa9e5a3d91132c4d93fe9362238459eb526 Step Tracegantt
title Run Online Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747825748000, 1747825750000
Collect Workflow Telemetry : 1747825750000, 1747825751000
Checkout code : 1747825751000, 1747825752000
Setup Rust : 1747825752000, 1747825768000
Cache dependencies : 1747825768000, 1747825771000
Copy input file : 1747825771000, 1747825771000
Preprocess inputs : 1747825771000, 1747825809000
Run online binary : 1747825809000, 1747825911000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / TestsWorkflow telemetry for commit ffa32fa9e5a3d91132c4d93fe9362238459eb526 Step Tracegantt
title Tests
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747825747000, 1747825749000
Collect Workflow Telemetry : 1747825749000, 1747825750000
Checkout code : 1747825750000, 1747825750000
Setup Rust : 1747825750000, 1747825763000
Cache dependencies : 1747825763000, 1747825764000
Run tests : 1747825764000, 1747825923000
Post Cache dependencies : 1747825923000, 1747825923000
Post Setup Rust : 1747825923000, 1747825923000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Marlin BinaryWorkflow telemetry for commit ffa32fa9e5a3d91132c4d93fe9362238459eb526 Step Tracegantt
title Run Marlin Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747825746000, 1747825748000
Collect Workflow Telemetry : 1747825748000, 1747825748000
Checkout code : 1747825748000, 1747825749000
Setup Rust : 1747825749000, 1747825763000
Cache dependencies : 1747825763000, 1747825764000
Run marlin binary : 1747825764000, 1747826241000
Post Cache dependencies : 1747826241000, 1747826242000
Post Setup Rust : 1747826242000, 1747826242000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Werewolf BinaryWorkflow telemetry for commit ffa32fa9e5a3d91132c4d93fe9362238459eb526 Step Tracegantt
title Run Werewolf Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1747825748000, 1747825750000
Collect Workflow Telemetry : 1747825750000, 1747825751000
Checkout code : 1747825751000, 1747825752000
Setup Rust : 1747825752000, 1747825770000
Cache dependencies : 1747825770000, 1747825772000
Run werewolf init : 1747825772000, 1747825835000
Run werewolf night : 1747825835000, 1747825861000
Run werewolf vote : 1747825861000, 1747825965000
Run werewolf judgment : 1747825965000, 1747826181000
Run werewolf role assignment : 1747826181000, 1747826414000
Post Cache dependencies : 1747826414000, 1747826415000
CPU MetricsMemory MetricsIO Metrics
|
|
@taskooh Could you review this PR? |
Workflow Telemetry - Rust CI / Run Groth16 BinaryWorkflow telemetry for commit ee50f5d186531750c658b46ed3ec0677c70cfc3b Step Tracegantt
title Run Groth16 Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749032947000, 1749032949000
Collect Workflow Telemetry : 1749032949000, 1749032949000
Checkout code : 1749032949000, 1749032950000
Setup Rust : 1749032950000, 1749032952000
Cache dependencies : 1749032952000, 1749032952000
Run groth16 binary : 1749032952000, 1749033045000
Post Cache dependencies : 1749033045000, 1749033047000
Post Setup Rust : 1749033047000, 1749033053000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Online BinaryWorkflow telemetry for commit ee50f5d186531750c658b46ed3ec0677c70cfc3b Step Tracegantt
title Run Online Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749032947000, 1749032949000
Collect Workflow Telemetry : 1749032949000, 1749032949000
Checkout code : 1749032949000, 1749032950000
Setup Rust : 1749032950000, 1749032951000
Cache dependencies : 1749032951000, 1749032952000
Copy input file : 1749032952000, 1749032952000
Preprocess inputs : 1749032952000, 1749033011000
Run online binary : crit, 1749033011000, 1749033096000
Post Cache dependencies : done, 1749033096000, 1749033096000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / TestsWorkflow telemetry for commit ee50f5d186531750c658b46ed3ec0677c70cfc3b Step Tracegantt
title Tests
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749032947000, 1749032951000
Collect Workflow Telemetry : 1749032951000, 1749032951000
Checkout code : 1749032951000, 1749032952000
Setup Rust : 1749032952000, 1749032955000
Cache dependencies : 1749032955000, 1749032955000
Run tests : 1749032955000, 1749033169000
Post Cache dependencies : 1749033169000, 1749033172000
Post Setup Rust : 1749033172000, 1749033178000
Post Checkout code : 1749033178000, 1749033178000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Marlin BinaryWorkflow telemetry for commit ee50f5d186531750c658b46ed3ec0677c70cfc3b Step Tracegantt
title Run Marlin Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749032947000, 1749032948000
Collect Workflow Telemetry : 1749032948000, 1749032948000
Checkout code : 1749032948000, 1749032949000
Setup Rust : 1749032949000, 1749032952000
Cache dependencies : 1749032952000, 1749032952000
Run marlin binary : 1749032952000, 1749033483000
Post Cache dependencies : 1749033483000, 1749033485000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Werewolf BinaryWorkflow telemetry for commit ee50f5d186531750c658b46ed3ec0677c70cfc3b Step Tracegantt
title Run Werewolf Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749032946000, 1749032948000
Collect Workflow Telemetry : 1749032948000, 1749032948000
Checkout code : 1749032948000, 1749032949000
Setup Rust : 1749032949000, 1749032950000
Cache dependencies : 1749032950000, 1749032951000
Run werewolf init : 1749032951000, 1749033069000
Run werewolf night : 1749033069000, 1749033095000
Run werewolf vote : 1749033095000, 1749033201000
Run werewolf judgment : 1749033201000, 1749033418000
Run werewolf role assignment : 1749033418000, 1749033649000
Post Cache dependencies : 1749033649000, 1749033652000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Groth16 BinaryWorkflow telemetry for commit eb1cd1d46e736b75976b833d708bfa2d0680e633 Step Tracegantt
title Run Groth16 Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749034526000, 1749034529000
Collect Workflow Telemetry : 1749034529000, 1749034529000
Checkout code : 1749034529000, 1749034530000
Setup Rust : 1749034530000, 1749034536000
Cache dependencies : 1749034536000, 1749034538000
Run groth16 binary : 1749034538000, 1749034588000
Post Cache dependencies : 1749034588000, 1749034588000
Post Setup Rust : 1749034588000, 1749034588000
Post Checkout code : 1749034588000, 1749034588000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Online BinaryWorkflow telemetry for commit eb1cd1d46e736b75976b833d708bfa2d0680e633 Step Tracegantt
title Run Online Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749034526000, 1749034528000
Collect Workflow Telemetry : 1749034528000, 1749034528000
Checkout code : 1749034528000, 1749034529000
Setup Rust : 1749034529000, 1749034533000
Cache dependencies : 1749034533000, 1749034534000
Copy input file : 1749034534000, 1749034534000
Preprocess inputs : 1749034534000, 1749034573000
Run online binary : 1749034573000, 1749034675000
Post Cache dependencies : 1749034675000, 1749034675000
Post Setup Rust : 1749034675000, 1749034675000
Post Checkout code : 1749034675000, 1749034676000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / TestsWorkflow telemetry for commit eb1cd1d46e736b75976b833d708bfa2d0680e633 Step Tracegantt
title Tests
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749034526000, 1749034529000
Collect Workflow Telemetry : 1749034529000, 1749034529000
Checkout code : 1749034529000, 1749034530000
Setup Rust : 1749034530000, 1749034535000
Cache dependencies : 1749034535000, 1749034536000
Run tests : 1749034536000, 1749034706000
Post Cache dependencies : 1749034706000, 1749034707000
Post Setup Rust : 1749034707000, 1749034707000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Marlin BinaryWorkflow telemetry for commit eb1cd1d46e736b75976b833d708bfa2d0680e633 Step Tracegantt
title Run Marlin Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749034527000, 1749034529000
Collect Workflow Telemetry : 1749034529000, 1749034529000
Checkout code : 1749034529000, 1749034531000
Setup Rust : 1749034531000, 1749034536000
Cache dependencies : 1749034536000, 1749034538000
Run marlin binary : 1749034538000, 1749035016000
CPU MetricsMemory MetricsIO Metrics
|
Workflow Telemetry - Rust CI / Run Werewolf BinaryWorkflow telemetry for commit eb1cd1d46e736b75976b833d708bfa2d0680e633 Step Tracegantt
title Run Werewolf Binary
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1749034526000, 1749034528000
Collect Workflow Telemetry : 1749034528000, 1749034528000
Checkout code : 1749034528000, 1749034529000
Setup Rust : 1749034529000, 1749034532000
Cache dependencies : 1749034532000, 1749034533000
Run werewolf init : 1749034533000, 1749034597000
Run werewolf night : 1749034597000, 1749034624000
Run werewolf vote : 1749034624000, 1749034728000
Run werewolf judgment : 1749034728000, 1749034943000
Run werewolf role assignment : 1749034943000, 1749035183000
Post Cache dependencies : 1749035183000, 1749035183000
CPU MetricsMemory MetricsIO Metrics
|
taskooh
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
PR全体をレビューしました。
変更概要
- AnonymousVotingCircuit から is_most_voted_id フィールドを削除し、投票結果は calculate_output メソッドで動的に計算する形にリファクタリングされています。
- 各種構造体・トレイトに serde::{Serialize, Deserialize} を追加し、シリアライズ/デシリアライズ対応が強化されています。
- 依存クレートに serde を追加し、既存の is_most_voted_id フィールド利用箇所を calculate_output() 呼び出しに置換しています。
- 不要となったシリアライズ/デシリアライズ処理の削除、テスト・バイナリ・サンプルコードの該当部分も修正されています。
技術的観点
- 冗長なフィールドの削除によりデータの一貫性が向上しています。
- シリアライズ対応の拡充で今後のデータ保存・通信の拡張性が高まりました。
- サンプルやテストも含めて is_most_voted_id の削除に追従しており、一貫性があります。
気になる点・確認事項
- calculate_output のロジックが従来の is_most_voted_id の値と完全に一致するか、テストでカバーされているか要確認です。
- serde の derive追加により、不要なフィールドまでシリアライズされていないか（特に秘密情報）ご注意ください。
- 既存の外部インターフェース（APIやファイルフォーマット）に互換性問題がないかも念のためご確認ください。
CI・テスト状況
- CI（Groth16/Marlin/Online/Werewolfバイナリ実行、テスト）は全てパスしています。
- 追加・修正されたテストコードの内容も問題ありません。
総評
- リファクタリングとして妥当で、保守性・拡張性が向上する良い変更です。
- 追加のテストや、シリアライズ対象フィールドの見直し（必要なら #[serde(skip)] など）を検討しても良いでしょう。
Approveします。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.