Skip to content

add magic ball game - #69

Merged
Yugo206 merged 2 commits into
Yugo206:mainfrom
shivsdev2:magic-ball-game
Jun 21, 2026
Merged

add magic ball game#69
Yugo206 merged 2 commits into
Yugo206:mainfrom
shivsdev2:magic-ball-game

Conversation

@shivsdev2

Copy link
Copy Markdown
Contributor

@shivsdev2
shivsdev2 requested a review from Yugo206 as a code owner June 14, 2026 17:42
@Yugo206 Yugo206 linked an issue Jun 14, 2026 that may be closed by this pull request

@Yugo206 Yugo206 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

The idea is good and fits the project, but there's a major problem: the result is returned but never displayed to the user.

Furthermore, the data entered by the user is currently not used in the game logic.

Please update the code to display the response and ensure the interaction is visible in the terminal. After that, I can merge it with the project.

@shivsdev2

Copy link
Copy Markdown
Contributor Author

Hello,
iam unsure what you mean by the data entered by the user is currently not used in the game logic.
the game gives random answers to any question, which is why the text does not change the answers.

If you want the input to actually influence the game logic,
we maybe can make the answer dependent of the length of the question or use random.seed() which will make the answer consistent for same questions.

@Yugo206 Yugo206 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification!

You're right, for a magic ball game, the fact that the answer is random and independent of the question makes perfect sense. My main concern was ensuring that the generated answer was displayed correctly to the player.

If your latest edit fixes this issue, then the game's logic is sound, and I don't think the question should influence the result. Therefore, I can merge the changes.

@Yugo206
Yugo206 merged commit a55fbde into Yugo206:main Jun 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Magic Ball game

2 participants