Skip to content

Alien Market trading game - #99

Merged
Yugo206 merged 4 commits into
Yugo206:mainfrom
adjenk:alien_market
Aug 5, 2026
Merged

Alien Market trading game#99
Yugo206 merged 4 commits into
Yugo206:mainfrom
adjenk:alien_market

Conversation

@adjenk

@adjenk adjenk commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Description

Hi @Yugo206 I've started on an alien market trading game. What do you think?

Checklist

  • My game defines an AUTHOR variable
  • My game defines a run() function
  • I did NOT add run() at the end of the file
  • I did NOT add if __name__ == "__main__"
  • I removed any .pyc files
  • I removed any .DS_Store files
  • The game works correctly when launched from launcher.py

Issue

Closes #83

@Yugo206 Yugo206 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, and sorry for the delay reviewing this! I really like the concept and the overall presentation. These are just a couple of small points I’d like to see addressed before merging.

Comment thread games/random/alien_market/game.py
Comment thread games/random/alien_market/game.py

@Yugo206 Yugo206 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! 🙌

The dead code following the bankruptcy return has indeed been removed.
The round limit (MAX_ROUNDS = 30) resolves the inconsistency with the description, and the "Round X/30" display is a nice touch.
The rebalancing (starting credits at 150, purchase cap at 80% of credits) is a welcome bonus; it also prevents dropping to zero credits just by buying cargo.
Nothing else to add—it looks ready to merge.

@Yugo206
Yugo206 merged commit 07eb8c3 into Yugo206:main Aug 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an Alien Market trading game

2 participants