Alien Market trading game - #99
Merged
Merged
Conversation
Yugo206
requested changes
Aug 3, 2026
Yugo206
left a comment
Owner
There was a problem hiding this comment.
Thanks for your patience, and sorry for the delay reviewing this! I really like the concept and the overall presentation. These are just a couple of small points I’d like to see addressed before merging.
Yugo206
approved these changes
Aug 5, 2026
Yugo206
left a comment
Owner
There was a problem hiding this comment.
Thanks for the quick fix! 🙌
The dead code following the bankruptcy return has indeed been removed.
The round limit (MAX_ROUNDS = 30) resolves the inconsistency with the description, and the "Round X/30" display is a nice touch.
The rebalancing (starting credits at 150, purchase cap at 80% of credits) is a welcome bonus; it also prevents dropping to zero credits just by buying cargo.
Nothing else to add—it looks ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi @Yugo206 I've started on an alien market trading game. What do you think?
Checklist
AUTHORvariablerun()functionrun()at the end of the fileif __name__ == "__main__".pycfiles.DS_Storefileslauncher.pyIssue
Closes #83