Add SMART status to disk infos #2046
Open
+866
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophehenry
force-pushed
the
storage-api-smartctl
branch
from
7e61308 to
9eee442
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| raise NotImplementedError | ||
|
|
||
|
|
||
| class AtaDisk(Disk, AtaController): ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| class AtaDisk(Disk, AtaController): ... | ||
|
|
||
|
|
||
| class NvmeDisk(Disk, NVMeController): ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
christophehenry
force-pushed
the
storage-api-smartctl
branch
2 times, most recently
from
7968937 to
8ee3ff7
Compare
- Also rewrite API using sdbus-python
christophehenry
force-pushed
the
storage-api-smartctl
branch
from
8ee3ff7 to
573daea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel: YunoHost/issues#1823
So this one may be a bit controversial since it rewrite the D-Bus part using
sdbus-pythonwhich is not yet bundled in Debian. I think, however usingsdbus-pythonwill have a positive effect on code since it D-Bus proxies are plain Python classes which improves code expressiveness and API discovery.