chore: update deps + refactoring

.eslintrc.cjs

@@ -5,12 +5,11 @@
 const config = {
   extends: [
     // The linter base is the shared IsaacScript config:
-    // https://github.com/IsaacScript/isaacscript/blob/main/packages/eslint-config-isaacscript/configs/base.js
+    // https://github.com/IsaacScript/isaacscript/blob/main/packages/eslint-config-isaacscript/base.js
     "eslint-config-isaacscript/base",
   ],
 
-  // Don't bother linting the compiled output.
-  // @template-ignore-next-line
+  // Don't bother linting compiled output.
   ignorePatterns: ["**/dist/**", "*.min.js"],
 
   parserOptions: {

.github/workflows/ci.yml

@@ -3,43 +3,28 @@ name: CI
 on: [push, pull_request]
 
 jobs:
-  build_and_lint:
+  build:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
+      - uses: actions/checkout@v4
+      - uses: ./.github/workflows/setup
+      - run: npm run build
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: lts/*
-          cache: yarn
-
-      - name: Retrieve the cached "node_modules" directory (if present)
-        uses: actions/cache@v3
-        id: node-cache
-        with:
-          path: node_modules
-          key: node-modules-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
-
-      - name: Install dependencies (if the cached directory was not found)
-        if: steps.node-cache.outputs.cache-hit != 'true'
-        run: yarn install --immutable
-
-      - name: Test to see if the project compiles
-        run: bash build.sh
-
-      - name: Perform automated checks
-        run: bash lint.sh
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ./.github/workflows/setup
+      - run: npm run lint
 
   # @template-customization-start
   discord:
     name: Discord Failure Notification
-    needs: [build_and_lint]
-    if: always() # This is needed to always run this job, even if the other jobs fail
+    needs: [build, lint]
+    if: always() # This is needed to always run this job, even if the other jobs fail.
     runs-on: ubuntu-latest
     steps:
-      - uses: technote-space/workflow-conclusion-action@v2
+      - uses: technote-space/workflow-conclusion-action@v3
       - if: env.WORKFLOW_CONCLUSION != 'success' && env.WORKFLOW_CONCLUSION != 'cancelled'
         uses: sarisia/actions-status-discord@v1
         with:

.github/workflows/setup/action.yml

@@ -0,0 +1,18 @@
+runs:
+  using: composite
+
+  steps:
+    # https://github.com/actions/setup-node/issues/899
+    - name: Enable corepack to work around a setup-node bug
+      run: corepack enable
+      shell: bash # Composite jobs must specify the shell.
+
+    - name: Setup Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: lts/*
+        cache: yarn
+
+    - name: Install dependencies
+      run: yarn install --immutable
+      shell: bash # Composite jobs must specify the shell.

.gitignore

@@ -9,6 +9,7 @@
 # --------------------------
 # GitHub .gitignore for Node
 # https://raw.githubusercontent.com/github/gitignore/master/Node.gitignore
+# cspell:disable
 # --------------------------
 
 # Logs

.vscode/settings.json

@@ -38,7 +38,7 @@
   // Extension settings
   // ------------------
 
-  // Use Prettier to format "cspell.json".
+  // Use Prettier to format "cspell.jsonc".
   "cSpell.autoFormatConfigFile": true,
 
   // -----------------
@@ -53,74 +53,23 @@
   "javascript.preferences.importModuleSpecifier": "relative",
   "typescript.preferences.importModuleSpecifier": "relative",
 
+  // By default, VSCode will not add `import type` automatically.
+  "typescript.preferences.preferTypeOnlyAutoImports": true,
+
   // Show TypeScript errors for files that don't happen to be currently open, which makes TypeScript
   // work similar to other compiled languages like Golang or Rust.
   "typescript.tsserver.experimental.enableProjectDiagnostics": true,
 
   // Automatically run the formatter when certain files are saved.
-  "[javascript]": {
-    "editor.codeActionsOnSave": {
-      "source.fixAll.eslint": "explicit",
-    },
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-    "editor.tabSize": 2,
-  },
-  "[typescript]": {
+  "[javascript][typescript][javascriptreact][typescriptreact]": {
     "editor.codeActionsOnSave": {
       "source.fixAll.eslint": "explicit",
     },
     "editor.defaultFormatter": "esbenp.prettier-vscode",
     "editor.formatOnSave": true,
     "editor.tabSize": 2,
   },
-  "[javascriptreact]": {
-    "editor.codeActionsOnSave": {
-      "source.fixAll.eslint": "explicit",
-    },
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-    "editor.tabSize": 2,
-  },
-  "[typescriptreact]": {
-    "editor.codeActionsOnSave": {
-      "source.fixAll.eslint": "explicit",
-    },
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-    "editor.tabSize": 2,
-  },
-  "[json]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-    "editor.tabSize": 2,
-  },
-  "[jsonc]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-    "editor.tabSize": 2,
-  },
-  "[yaml]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-    "editor.tabSize": 2,
-  },
-  "[markdown]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-    "editor.tabSize": 2,
-  },
-  "[html]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-    "editor.tabSize": 2,
-  },
-  "[css]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-    "editor.tabSize": 2,
-  },
-  "[postcss]": {
+  "[css][html][json][jsonc][markdown][postcss][yaml]": {
     "editor.defaultFormatter": "esbenp.prettier-vscode",
     "editor.formatOnSave": true,
     "editor.tabSize": 2,

cspell.json → cspell.jsonc

@@ -1,49 +1,55 @@
 {
   "$schema": "https://raw.githubusercontent.com/streetsidesoftware/cspell/main/cspell.schema.json",
   "version": "0.2",
+  // @template-ignore-next-line
   "import": ["isaacscript-spell/cspell-isaacscript.json"],
   "files": ["**"],
   "enableFiletypes": ["*"],
   "enableGlobDot": true,
   "useGitignore": true,
   "ignorePaths": [
-    "*.anm2",
-    "*.css",
-    "*.icns",
     "*.min.js",
     "*.mp3",
-    "*.node",
-    "*.otf",
     "*.pyc",
     "*.svg",
-    "*.wav",
     ".git/**",
     ".yarn/**",
+    "dist/**",
+    "LICENSE",
+    "node_modules/**",
+    "package-lock.json",
+    "pnpm-lock.yaml",
+    "yarn.lock",
+    // @template-customization-start
+    "*.anm2",
+    "*.css",
+    "*.icns",
+    "*.node",
+    "*.otf",
+    "*.wav",
     "alpha.css",
     "alpha-old.css",
-    "dist/**",
     "jquery-lang.js",
-    "node_modules/**",
     "main-vanilla.lua",
     "main-combined.lua",
     "mod/**/*.anm2",
     "mod/main.lua",
     "mod/resources/rooms/**",
-    "package-lock.json",
-    "pnpm-lock.yaml",
     "word-list.txt",
-    "yarn.lock"
+    // @template-customization-end
   ],
   "words": [
     "asar",
     "datetime",
     "dofiling",
+    "dotenv",
     "greenworks",
     "hkcu",
     "HOSTNAMES",
-    "icns",
     "jquery",
     "kadda",
+    "klaw",
+    "knip",
     "linkify",
     "linkifyjs",
     "loadlib",
@@ -71,6 +77,6 @@
     "unmaximize",
     "unshutdown",
     "Voss",
-    "WASAPI"
-  ]
+    "WASAPI",
+  ],
 }

knip.jsonc

@@ -0,0 +1,5 @@
+{
+  "$schema": "https://unpkg.com/knip@3/schema-jsonc.json",
+  "ignore": [".eslintrc.cjs", "prettier.config.mjs"],
+  "ignoreDependencies": ["isaacscript-lint"],
+}