Skip to content

Improve FAQ accordion accessibility #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huazhuang80-star wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve FAQ accordion accessibility #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions components/landing/faq.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";

import { useState } from "react";
import { useId, useState } from "react";
import { ChevronDown } from "lucide-react";
import { Reveal } from "@/components/landing/reveal";
import { SectionLabel } from "@/components/landing/section-label";
Expand All @@ -9,6 +9,7 @@ import { FAQ_CATEGORIES, FAQ_ITEMS, type FaqCategory } from "@/lib/faq";
import { cn } from "@/lib/utils";

export function Faq() {
const faqIdPrefix = useId();
const [category, setCategory] = useState<FaqCategory>("about");
const [openIndex, setOpenIndex] = useState<number | null>(0);

Expand Down Expand Up @@ -37,9 +38,10 @@ export function Faq() {
<button
key={id}
type="button"
aria-pressed={category === id}
onClick={() => selectCategory(id)}
className={cn(
"px-4 py-2 text-[10px] font-bold uppercase tracking-zk border transition-colors zk-badge",
"px-4 py-2 text-[10px] font-bold uppercase tracking-zk border transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-white/50 focus-visible:ring-offset-2 focus-visible:ring-offset-black zk-badge",
category === id
? "border-white/30 bg-white/10 text-white"
: "border-white/10 bg-transparent text-white/40 hover:text-white/70 hover:border-white/20"
Expand All @@ -53,27 +55,38 @@ export function Faq() {
<div className="max-w-3xl mx-auto border border-white/[0.08] bg-[#0a0a0a]/60">
{items.map(({ question, answer }, i) => {
const isOpen = openIndex === i;
const buttonId = `${faqIdPrefix}-${category}-${i}-trigger`;
const panelId = `${faqIdPrefix}-${category}-${i}-panel`;

return (
<div
key={question}
className="border-b border-white/[0.06] last:border-0"
>
<button
id={buttonId}
type="button"
aria-expanded={isOpen}
aria-controls={panelId}
onClick={() => setOpenIndex(isOpen ? null : i)}
className="w-full flex items-center justify-between gap-4 px-5 py-4 text-left hover:bg-white/[0.02] transition-colors"
className="w-full flex items-center justify-between gap-4 px-5 py-4 text-left hover:bg-white/[0.02] transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-white/50"
>
<span className="text-sm font-bold tracking-wide text-white/90">
{question}
</span>
<ChevronDown
aria-hidden="true"
className={cn(
"w-4 h-4 shrink-0 text-white/40 transition-transform",
isOpen && "rotate-180"
)}
/>
</button>
<div
id={panelId}
role="region"
aria-labelledby={buttonId}
aria-hidden={!isOpen}
className={cn(
"overflow-hidden transition-all duration-300",
isOpen ? "max-h-96 opacity-100" : "max-h-0 opacity-0"
Expand Down