Skip to content

Conversation

@DenisBiryukov91
Copy link

No description provided.

@DenisBiryukov91 DenisBiryukov91 marked this pull request as draft May 28, 2025 09:47
@virtualzettler virtualzettler requested a review from Copilot May 28, 2025 09:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR, titled "Binary format", introduces multiple changes to improve serialization and encoding functionality as well as updates to various examples and plugin modules.

  • Updated serialization and deserialization logic in the core library.
  • Refactored encoding API and updated example usage with new language features.
  • Adjusted plugin remote API, including dependency revisions and removal of unused files.

Reviewed Changes

Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
zenoh-ts/src/ext/serialization.ts Updates to buffer management and serialization methods; potential issue in finish() method.
zenoh-ts/src/enums.ts Enum definitions updated for priority, reliability and others.
zenoh-ts/src/encoding.ts Refactored Encoding class implementation with new enum based design.
zenoh-ts/examples/deno/* Examples updated to use new language idioms and name changes.
zenoh-plugin-remote-api/src/lib.rs Plugin remote API refactor; added dependency updates and changes to AdminSpaceClient.
Other plugin files Removed obsolete serialization/deserialization modules.
Comments suppressed due to low confidence (1)

zenoh-plugin-remote-api/src/lib.rs:278

  • The register_subscriber() method incorrectly inserts the key expression into the publishers map instead of the subscribers map. Update the method to use self.subscribers.insert(...) accordingly.
self.publishers.insert(id, key_expr.toString());

this.data = new Array();
this.len = 0;
this.bufferLen = 0;
return new ZBytes(out);
Copy link

Copilot AI May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The finish() method wraps an already constructed ZBytes instance in a new ZBytes call, which appears unintended. It is recommended to return 'out' directly.

Suggested change
return new ZBytes(out);
return out;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant