You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the Windows compatibility fix. Replacing fcntl with a cross-platform lock is the right direction, but I would not merge this PR as-is.
Please address these before merge:
Restore .gitignore
The PR deletes the entire .gitignore. That would make local artifacts, test caches, build outputs, databases, reports, and especially .env files easy to commit accidentally. This is unrelated to the filelock fix and should be reverted.
Sync dependency declarations
pyproject.toml adds filelock>=3.12, but requirements.txt still omits it. If requirements.txt remains a supported install path, importing alphaevo.data.cache will fail in that environment.
Preserve lock-file cleanup on exceptions
The new _file_lock implementation cleans up the .lock file only after the with lock: block completes normally. If code inside the lock raises, the lock should still be released by FileLock, but the best-effort lock_path.unlink() cleanup is skipped. Please wrap the yield in try/finally so the old cleanup behavior is preserved.
The core code change is small and useful; after those fixes, this should be much safer to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.