#449 add explicit to node constructor (#484)

* Changes defines in include guards to avoid undefined behaviour * Adds Explicit constructor to Node class (#449) * Update cmake.yml to run tests --------- Co-authored-by: Olek Raymond <[email protected]>
ZigRazor · Feb 3, 2025 · 1e6b0ce · 1e6b0ce
1 parent 985625e
commit 1e6b0ce
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
@@ -2,9 +2,7 @@ name: CMake
 
 on:
   push:
-    branches: [ master ]
   pull_request:
-    branches: [ master ]
 
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)

diff --git a/include/CXXGraph/Node/Node_decl.h b/include/CXXGraph/Node/Node_decl.h
@@ -43,7 +43,7 @@ class Node {
 
   Node(const std::string &, const T &data);
   // Move constructor
-  Node(const std::string &, T &&data) noexcept;
+  explicit Node(const std::string &, T &&data) noexcept;
   ~Node() = default;
   const CXXGraph::id_t &getId() const;
   const std::string &getUserId() const;