Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build #486

Open
JustCallMeRay opened this issue Jan 7, 2025 · 1 comment
Open

Windows build #486

JustCallMeRay opened this issue Jan 7, 2025 · 1 comment

Comments

@JustCallMeRay
Copy link
Contributor

Describe the bug
The windows build is broken at the CMake configure step.
Seems to be path separators in the source dir argument, CMake prefers the Linux style paths.
image

To Reproduce
Steps to reproduce the behaviour:

  1. Run the windows build
  2. See the windows build fails in the configure CMake step

Expected behaviour
A clear and concise description of what you expected to happen.

  • The windows build to run
  • Tests to run

Desktop (please complete the following information):

  • See github actions on master for full log and machine information
OlekRaymond added a commit to OlekRaymond/CXXGraph that referenced this issue Jan 7, 2025
OlekRaymond added a commit to OlekRaymond/CXXGraph that referenced this issue Jan 7, 2025
OlekRaymond added a commit to OlekRaymond/CXXGraph that referenced this issue Jan 7, 2025
@JustCallMeRay
Copy link
Contributor Author

The Windows build now runs from start to finish including running all the tests

A test does fail on Windows but I don't intend to fix it under this ticket (feels out of scope) though I can if asked, either as a new ticket or under this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant