Skip to content

Optimize GPU backend and crypto primitives #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
this-vishalsingh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize GPU backend and crypto primitives #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions crates/primitives/benches/m31_sbox.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//! difference between M31 (which requires x^5 or higher) and fields like
//! Koalabear/BabyBear that could use cheaper sboxes like x^3.

use criterion::{black_box, criterion_group, criterion_main, Criterion, BenchmarkId};
use criterion::{black_box, criterion_group, criterion_main, BenchmarkId, Criterion};
use zp1_primitives::M31;

/// Compute x^3 (simulating cheaper sbox, e.g. Koalabear if valid)
Expand Down Expand Up @@ -37,21 +37,13 @@ fn bench_field_ops(c: &mut Criterion) {
let a = M31::new(0x12345678);
let b = M31::new(0x7654321);

group.bench_function("add", |bench| {
bench.iter(|| black_box(a) + black_box(b))
});
group.bench_function("add", |bench| bench.iter(|| black_box(a) + black_box(b)));

group.bench_function("mul", |bench| {
bench.iter(|| black_box(a) * black_box(b))
});
group.bench_function("mul", |bench| bench.iter(|| black_box(a) * black_box(b)));

group.bench_function("square", |bench| {
bench.iter(|| black_box(a).square())
});
group.bench_function("square", |bench| bench.iter(|| black_box(a).square()));

group.bench_function("inverse", |bench| {
bench.iter(|| black_box(a).inv())
});
group.bench_function("inverse", |bench| bench.iter(|| black_box(a).inv()));

group.finish();
}
Expand Down Expand Up @@ -89,7 +81,9 @@ fn bench_batch_sbox(c: &mut Criterion) {
] {
group.bench_with_input(BenchmarkId::new(name, "1000"), &batch, |bench, data| {
bench.iter(|| {
data.iter().map(|&x| sbox_fn(black_box(x))).collect::<Vec<_>>()
data.iter()
.map(|&x| sbox_fn(black_box(x)))
.collect::<Vec<_>>()
})
});
}
Expand Down
Loading