Add id3v2 mappings for MusicBrainz and Vorbis tags#60
Open
dajhorn wants to merge 2 commits intoZivaVatra:masterfrom
Open
Add id3v2 mappings for MusicBrainz and Vorbis tags#60dajhorn wants to merge 2 commits intoZivaVatra:masterfrom
dajhorn wants to merge 2 commits intoZivaVatra:masterfrom
Conversation
Resolve this build warning: /usr/local/lib/python3.10/dist-packages/flac2all-5.5-py3.10.egg/flac2all_pkg/core.py:248: SyntaxWarning: "is" with a literal. Did you mean "=="? if opts['nodirs'] is "d": /usr/local/lib/python3.10/dist-packages/flac2all-5.5-py3.10.egg/flac2all_pkg/core.py:253: SyntaxWarning: "is" with a literal. Did you mean "=="? elif opts['nodirs'] is "m":
Preserve FLAC metadata (metaflac comments) from music libraries that are managed by Picard or other compatible management tools. https://picard-docs.musicbrainz.org/en/appendices/tag_mapping.html
Owner
|
Has this been tested for regression from music libraries not managed by the tools you mentioned? |
Author
|
This is not tested against non-MetaBrainz input short of preserving existing behavior for id3v1 and CDDB tags. Output was tested with Foobar2000, Clementine, Windows Media Player, and the CD-R player in my car. I noticed one glitch: Picard will write out a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve FLAC metadata (metaflac comments) from music libraries that are
managed by Picard or other compatible management tools.
https://picard-docs.musicbrainz.org/en/appendices/tag_mapping.html