Skip to content

Testing Feedback 3 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Testing Feedback 3 #23

merged 2 commits into from
Apr 9, 2025

Conversation

chcmedeiros
Copy link
Contributor

  • For legacy and eip2930 remove gas limit and price
  • Show max fees instead

@chcmedeiros
Compute Max Fees
a294faa 
- For legacy and eip2930 remove gas limit and price
- Show max fees instead
@chcmedeiros
update snapshots
c589fe6
emmanuelm41
emmanuelm41 reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not so sure about the pageIdx being increased or decreased, while no new field is added. We are just changing the name of one.

app/src/evm/evm_utils.c
Comment on lines +216 to +217
uint256_t max_fees = {0};
mul256(&gas_limit, &gas_price, &max_fees);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we handling overflows here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we handle the overflows inside the function. It is replicating the eth app functionality.

@chcmedeiros
Copy link
Contributor Author

I am not so sure about the pageIdx being increased or decreased, while no new field is added. We are just changing the name of one.

For legacy and 2930 we will be showing the max fee instead of gas limit and gas price. So one less field.
But we will keep showing the gas limit for 1539.
These 3 EIPs are supported in the same printing function so we do the displayIxd handling in the beginning of the function.

@chcmedeiros chcmedeiros merged commit b1b65ae into dev Apr 9, 2025
54 checks passed
@chcmedeiros chcmedeiros deleted the improvements branch April 9, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 left review comments

@abenso abenso abenso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chcmedeiros @emmanuelm41 @abenso