Shell script to minimally test supported models on a real dataset #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-r-r-o-w
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Thanks Sayak! The changes look good.
I'm always a bit skeptic about using rm -rf in scripts, but it's alright for now. I will take up some future test additions to run these from pytest (similar to our test lora scripts), so that we can use TemporaryDirectory() and all the python goodies
Yes, I am working on testing with dummy small checkpoints in a formal manner i.e., like we do in Diffusers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have run and can confirm it's working as expected. Since this script will be used quite (or so I think) heavily, I would appreciate if you could run it, too.