[WIP][tests] add precomputation tests #234
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Jan 21, 2025
sayakpaul
commented
Jan 21, 2025
Comment on lines
18
to
21
| try: | ||
| tokenizer = T5Tokenizer.from_pretrained(model_id, subfolder="tokenizer", revision=revision, cache_dir=cache_dir) | ||
| except: | ||
| tokenizer = AutoTokenizer.from_pretrained(model_id, subfolder="tokenizer", revision=revision, cache_dir=cache_dir) |
There was a problem hiding this comment.
Not super proud of this but we cannot do T5Tokenizer on the dummy T5 tokenizer checkpoint. Some sentencepiece error.
sayakpaul
commented
Jan 21, 2025
sayakpaul
commented
Jan 21, 2025
Comment on lines
+18
to
+25
| try: | ||
| tokenizer = T5Tokenizer.from_pretrained( | ||
| model_id, subfolder="tokenizer", revision=revision, cache_dir=cache_dir | ||
| ) | ||
| except: # noqa | ||
| tokenizer = AutoTokenizer.from_pretrained( | ||
| model_id, subfolder="tokenizer", revision=revision, cache_dir=cache_dir | ||
| ) |
There was a problem hiding this comment.
Not proud of the change but T5Tokenizer cannot be used on a dummy T5 tokenizer ckpt.
sayakpaul
commented
Jan 21, 2025
a-r-r-o-w
reviewed
Jan 22, 2025
|
@a-r-r-o-w LMK what you think of the latest changes. |
a-r-r-o-w
reviewed
Jan 26, 2025
| root_dir = current_file.parents[3] | ||
| sys.path.append(str(root_dir)) | ||
|
|
||
| import unittest # noqa |
There was a problem hiding this comment.
Just curious as to why these imports have to be marked noqa?
There was a problem hiding this comment.
Resolved them. Should be good now.
Co-authored-by: a-r-r-o-w <[email protected]>
|
@a-r-r-o-w LMK if I can apply the tests to the rest of the models. I have taken care of addressing the rest of your feedback. |
|
Yes please, lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds precomputation tests.
Currently, I have changed the bare-minimum to show the approach taken for the tests. After I have some reviews, I will propagate the changes to the rest of the supported models and make the PR ready for further reviews.
Some further comments in-line.
To run the tests from DGX or any other internal CUDA machines without using CUDA, run:
CUDA_VISIBLE_DEVICES="" pytest tests/trainers/Just LMK if you want something change before proceeding to review at this stage of the PR. I will make it happen.
TODOs