Skip to content

Conversation

@reallocf
Copy link
Collaborator

@reallocf reallocf commented Jan 5, 2022

This works with the current settings - @aadharna do you want to try this with a more complicated run? We may need to bump up allocated memory and stuff, and we'll probably need to play with it more with a GPU to see how we can get it to work - maybe we can talk about it during our Weds meeting?

@aadharna
Copy link
Owner

aadharna commented Jan 5, 2022

Sounds good. We can chat tomorrow!

@@ -0,0 +1,5 @@
FROM rayproject/ray-ml:1.6.0

COPY . .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this dump everything into /? If so, we might want to do:

COPY . /src
WORKDIR /src

just to keep things organized

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like this container puts things in /home/ray/ be default.

Interestingly, when I write this to another location I get that error you were seeing last week. For example, when trying to put it in ./src aka home/ray/src I get:

#8 9.786          cwd: /home/ray/src/
#8 9.786     Complete output (4 lines):
#8 9.786     running develop
#8 9.786     running egg_info
#8 9.786     creating watts.egg-info
#8 9.786     error: could not create 'watts.egg-info': Permission denied

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But when I just leave it in . aka home/ray/ it works fine 🤷‍♀️

It probably has something to do with the linux permissions in the container - but I haven't dug into it too deep. My docker-fu is pretty weak.

Copy link
Owner

@aadharna aadharna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. We should just add filesystem mounting so that we can save stuff to disk. Was there another feature we mentioned wanting Charlie? If so, I have forgotten what it was.

@aadharna
Copy link
Owner

aadharna commented Jan 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants