-
Notifications
You must be signed in to change notification settings - Fork 0
Dockerize watts #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Dockerize watts #35
Conversation
|
Sounds good. We can chat tomorrow! |
| @@ -0,0 +1,5 @@ | |||
| FROM rayproject/ray-ml:1.6.0 | |||
|
|
|||
| COPY . . | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this dump everything into /? If so, we might want to do:
COPY . /src
WORKDIR /src
just to keep things organized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like this container puts things in /home/ray/ be default.
Interestingly, when I write this to another location I get that error you were seeing last week. For example, when trying to put it in ./src aka home/ray/src I get:
#8 9.786 cwd: /home/ray/src/
#8 9.786 Complete output (4 lines):
#8 9.786 running develop
#8 9.786 running egg_info
#8 9.786 creating watts.egg-info
#8 9.786 error: could not create 'watts.egg-info': Permission denied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But when I just leave it in . aka home/ray/ it works fine 🤷♀️
It probably has something to do with the linux permissions in the container - but I haven't dug into it too deep. My docker-fu is pretty weak.
aadharna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. We should just add filesystem mounting so that we can save stuff to disk. Was there another feature we mentioned wanting Charlie? If so, I have forgotten what it was.
|
On the requirements side, I asked Chris how he'd handle a docker container
for griddly and he sent me: "So I use docker images when things are built
in the CI server, so you can look in the scripts in the azurepipelines.yaml
to see whats installed."
Here's a link to the yml file chris mentions: `https://github.com/aadharna/Griddly/blob/develop/azure-pipelines.yml`
|
4d9f316 to
471c53e
Compare
This works with the current settings - @aadharna do you want to try this with a more complicated run? We may need to bump up allocated memory and stuff, and we'll probably need to play with it more with a GPU to see how we can get it to work - maybe we can talk about it during our Weds meeting?