oracle: Skip things in other splits #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…monstrations A flaw with the oracle was that it could generate demonstrations of things in splits B, C, D, E and F. Even though we weren't really trying to optimize performance on those splits, it makes benchmarks on them problematic, since we technically leak the solution in the demonstrations. This change reworks the oracle so that generating those demonstrations is not possible in the training set, unless it is the only viable demonstration. Instead we generate demonstrations of going to *different* objects and try to learn from those. In the test data, we allow generating demonsrtations of other splits other than the one being tested.
Useful for debugging data generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.