Closed
Conversation
…, with unit tests
…e use of a very old web3 library version, incompatible with Injective SDK library
…ich has many zero after the decimal point, you will not able to place order on the mexc, since the number will be converted to scientific notation.
…ngbot into feat/fixed-rate-amm-arb
…ing_rules_logging Feat/improve trading rules logging
fix/MEXC exchange, when the token price is super small
…m-arb (feat) add fixed rate conversion for amm-arb
Feat/dex data feed
…tor-changes (gov) epoch 5 changes
Fix/change default global_token_name to USDT
…, with unit tests
…e use of a very old web3 library version, incompatible with Injective SDK library
…com/aarmoa/hummingbot into feat/injective_spot_with_delegation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Implementation of a new Injective spot connector.
The new connector does not require Gateway (pure Python connector) and has been implemented to trade with delegated accounts (ie: the trading account trades in representation of a granter account, that is the one having the funds).
The current connector implementation does not support market orders (only limit and limit maker). Market orders support will be added in a future version.
In order to use delegated accounts to trade it is necessary to perform a gran onchain. To send the grant transaction please use the script file
hummingbot/connector/exchange/injective_v2/account_delegation_script.py.NOTE:
There is a problem with the dYdX library. It has very hard restrictions on the possible versions to use for
web3, forcing the whole Hummingbot project to use an old version of that library and all other crypto related libraries required by web3 in place. Taking into account that it is critical for any crypto project to use the most updated library versions for security reasons, the restrictions imposed bydydx-v3-pythonare not acceptable. I think the only solutions the Hummingbot project has are:In this PR, to solve the library issue and allow the use of newer
web3versions, I changedenvironment.ymlfile to point to the branch of a PR sent already to the dYdX library project that solves the issue (dydxprotocol/dydx-v3-python#202). The PR was created in march in all this time the team has not merged it (and they don't show any intentions to merge it in the near future).Tests performed by the developer:
Created unit tests for all new components.
Tested the connector by running pure market making strategies.
Tips for QA testing:
Configure a delegate trading account and teste the connector using spot strategies.