-
Notifications
You must be signed in to change notification settings - Fork 1
docs: ADR-087 documentation overhaul (Phases 1-3) #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Non-technical foundation for all audiences: - README.md: 30-second explanation + "The Real Point" - how-it-works.md: Conceptual model without code - glossary.md: Plain language definitions Part of ADR-087 documentation overhaul.
Operator-focused guides: - README.md: Overview and quick commands - quick-start.md: 5-minute local setup - production.md: Full deployment with headless init, HTTPS, GPU - configuration.md: All settings reference - upgrading.md: Version upgrade procedures - backup-restore.md: Data protection - troubleshooting.md: Common issues and fixes Part of ADR-087 documentation overhaul.
Task-oriented documentation for users: - ingesting.md: Adding documents, formats, CLI/API/web workflows - exploring.md: Search, navigate relationships, find connections - querying.md: CLI commands, REST API, MCP tools for AI - understanding-grounding.md: Confidence, contradiction, epistemic status Part of ADR-087 documentation overhaul.
Documentation Review: ADR-087 ImplementationReviewed the documentation overhaul against ADR-087 requirements and actual implementation. Overall this is a strong implementation of the documentation strategy - well-organized, audience-appropriate, and largely accurate. Summary
1. ConsistencyTerminology is consistent across documents. Key terms (concept, grounding, ontology, source, evidence) are used uniformly. The glossary definitions match usage in other docs. Cross-references are mostly accurate but there are issues:
These reference directories exist but contain only stubs. The OpenAPI spec exists at
2. Completeness vs ADR-087Phase 1 (Concepts): Complete
Phase 2 (Operating): Complete
Phase 3 (Using): Complete
Missing from ADR-087 spec but noted as deferred:
The PR accurately represents scope - Phases 1-3 are complete per the specification. 3. Accuracy Verificationproduction.md vs headless-init.shVerified accurate:
Minor discrepancy at The table shows Suggest adding a note that compose file auto-selects based on prefix/source. configuration.md vs .env.exampleCoverage is good but some variables documented in
These are advanced/optional, so may be intentional omissions. Consider adding a brief "Advanced Configuration" section or noting where to find complete reference. CLI Commands in querying.mdIssue at The documented commands: kg concept details <concept-id>
kg concept related <concept-id>
kg concept connect --from "concept A" --to "concept B"Actual CLI structure (from search.ts): kg search details <concept-id>
kg search related <concept-id>
kg search connect <from> <to>The commands are subcommands of
This affects multiple files and should be corrected. Similarly, at kg auth login
kg auth logoutThese are actually registered as: kg login
kg logoutThe 4. Audience Appropriatenessconcepts/ - Non-technical: Excellent
operating/ - Operator-focused: Good
using/ - Task-oriented: Good
5. Quality IssuesBroken/Pending Links
Minor Gaps
kg search "vaccination effects" --show-contestedThis
kg vocabulary list --status CONTESTEDShould be
kg vocabulary list --status CONTESTED
kg search "topic" --status AFFIRMATIVESame issues - commands need verification against actual CLI implementation. Formatting Consistency
RecommendationsMust fix before merge:
Should fix: Consider for future: AI-assisted review via Claude. Verified against headless-init.sh, .env.example, and cli/src/cli/.ts.* |
- kg auth login/logout → kg login/logout - kg concept details/related/connect → kg search details/related/connect - Remove non-existent --show-contested flag Fixes issues identified in PR review.
Mark Phases 1-3 as complete after PR #207 merge. Phase 4 (reference) already exists as auto-generated docs.
Summary
Implements ADR-087 documentation strategy with audience-organized documentation.
The Real Point
This isn't just a knowledge graph. It's infrastructure for AI agents that can reason about what they know and how well they know it.
What's New
Phase 1: Concepts (non-technical foundation)
docs/concepts/README.md- 30-second explanationdocs/concepts/how-it-works.md- Conceptual model without codedocs/concepts/glossary.md- Plain-language definitionsPhase 2: Operating (operator guides)
docs/operating/README.md- Overview and quick commandsdocs/operating/quick-start.md- 5-minute local setupdocs/operating/production.md- Full deployment with headless init, HTTPS, GPUdocs/operating/configuration.md- All settings referencedocs/operating/upgrading.md- Version upgrade proceduresdocs/operating/backup-restore.md- Data protectiondocs/operating/troubleshooting.md- Common issues and fixesPhase 3: Using (user guides)
docs/using/README.md- Entry point for usersdocs/using/ingesting.md- Adding documentsdocs/using/exploring.md- Finding and navigating conceptsdocs/using/querying.md- CLI, API, and MCP accessdocs/using/understanding-grounding.md- Confidence and contradictionSix Audiences (from ADR-087)
Stats
Test Plan