Add role="switch" #187
Open
Add role="switch" #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing the following error on Node v22: TypeError: Cannot set property navigator of #<Object> which has only a getter Tests appear to work fine without it.
and add aria-disabled attribute to the "switch" element. Moved the focus and blur events to the div as well. This would affect anyone who has attached their own event handlers and is expecting the event target to be the input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools like Cypress don't play well with react-toggle because while the input exists, Cypress can tell that it is hidden. So you have to
cy.get('input', {force: true})to select it.By adding
role="switch" aria-checked="checked"it is possible to treat the visibledivas the interactive widget. When using testing-library we can then do things likeAs a knock on effect, I think other attributes also should be moved to the outer
divas well:aria-labelaria-labelledbyaria-disabledFinally, the input should no longer be needed for the screen reader, because the screen reader should understand that the div is the widget. The only purpose that the input serves (I think) would be so it could still be submitted as a form.