Add --date argument - closes #4 #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `--date` argument is passed, the script will filter from all events the ones that were created in the selected date. If no --date argument is passes, only today events are shown. Also add a pagination logic to fetch all results from Github API.
aashutoshrathi
approved these changes
Oct 10, 2018
Owner
|
Resolve conflicts and add new line at the end. |
ammarmallik
referenced
this pull request
Oct 18, 2018
WHAT: Replacing 'today' in print statements with the given date WHY: because of hardcode value, it doesn't print proper date IMPACT: MEDIUM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--dateargument is passed, the script will filter from allevents the ones that were created in the selected date.
If no
--dateargument is passed, only today events are shown.Also add a pagination logic to fetch all results from Github API.