Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge invitations into domains service #2679

Open
felixgateru opened this issue Feb 3, 2025 · 0 comments · May be fixed by #2676
Open

Merge invitations into domains service #2679

felixgateru opened this issue Feb 3, 2025 · 0 comments · May be fixed by #2676
Assignees

Comments

@felixgateru
Copy link
Contributor

@dborovcanin @felixgateru


Merging the Invitation Service with the Domains Service

Reason for the Merge

Previously, the Invitation service relied on permissions aka roles (Admin, Editor, Viewer), along with the domain and invited user ID. However, we have now introduced a new structure where a role is defined by a set of actions/permissions and is uniquely identified by a role_id.

Given this change, When creating a new invitation , Invitation service now requires access to:

  • role_id (to identify the assigned role, role_id resides in domains repo)
  • domain_id (to associate the invitation with a domain)
  • user_id (to identify the invited user)

Additionally, when listing invitations, we need to display the role name instead of just the role ID. This requires fetching role details from the Domains service.

Why Merge the Services?

  • The Invitation service needs access to the Domains repository to retrieve role details (e.g., role name from role_id).
  • Previously, Domains were part of the Auth service, but now Domains are an independent service.
  • Since Invitations require domain-related data, merging the two services simplifies the architecture and removes the need for an external repository dependency.
  • With this change, the invitation token becomes unnecessary, as invitation functions can directly access the required domain and role details.

Originally posted by @arvindh123 in #2435

@felixgateru felixgateru changed the title Merge invitations into domaisn service Merge invitations into domains service Feb 3, 2025
@felixgateru felixgateru self-assigned this Feb 3, 2025
@github-project-automation github-project-automation bot moved this to ⛏ Backlog in SuperMQ Feb 3, 2025
@felixgateru felixgateru moved this from ⛏ Backlog to 🚧 In Progress in SuperMQ Feb 3, 2025
@felixgateru felixgateru moved this from 🚧 In Progress to 🩺 Review and testing in SuperMQ Feb 4, 2025
@felixgateru felixgateru moved this from 🩺 Review and testing to 🚧 In Progress in SuperMQ Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚧 In Progress
Development

Successfully merging a pull request may close this issue.

1 participant