SMQ - 2435 - Merge invitations into domains service #2676
+4,388
−5,517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
mg2435-invitations
branch
4 times, most recently
from
2b8435b to
46ce73d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2676 +/- ##
==========================================
- Coverage 43.87% 36.85% -7.03%
==========================================
Files 350 295 -55
Lines 45718 42990 -2728
==========================================
- Hits 20059 15844 -4215
- Misses 23438 25924 +2486
+ Partials 2221 1222 -999 ☔ View full report in Codecov by Sentry. |
|
@arvindh123 Please review. |
arvindh123
requested changes
Feb 4, 2025
arvindh123
requested changes
Feb 5, 2025
felixgateru
force-pushed
the
mg2435-invitations
branch
from
fca5e76 to
b27986a
Compare
|
@arvindh123 Please re-review. |
arvindh123
requested changes
Feb 6, 2025
felixgateru
force-pushed
the
mg2435-invitations
branch
2 times, most recently
from
aadf5b7 to
8cd3cb6
Compare
arvindh123
requested changes
Feb 6, 2025
felixgateru
force-pushed
the
mg2435-invitations
branch
2 times, most recently
from
e693882 to
0e5ae37
Compare
arvindh123
requested changes
Feb 6, 2025
felixgateru
force-pushed
the
mg2435-invitations
branch
2 times, most recently
from
77fc6b3 to
4f74a2c
Compare
arvindh123
requested changes
Feb 10, 2025
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
felixgateru
force-pushed
the
mg2435-invitations
branch
from
4f74a2c to
7455631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor as it merges the invitations service into the domains service.
What does this do?
This pr removes the invitations service as a standalone service and moves functionality into the domains service.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have updated all relevant tests.
Did you document any new/modified feature?
Yes, in code documenation is included.
Notes
None.