Skip to content

Conversation

gian1200
Copy link

  • Updated jest execution command to handle dynamic import
  • All tests pass.
  • For security reasons, omitting package-lock.json in the commit so you can update it yourself.

@gian1200 gian1200 changed the title Update conventional-changelog to v5.1.0 chore(deps): update conventional-changelog to v5.1.0 Aug 16, 2025
@TimothyJones
Copy link
Member

Thanks for this! Apologies for missing it - I think I saw the title and assumed it was an automated update we couldn't apply 😅

Is this a breaking change for users who are using the API via jest (or other non-ESM-friendly environment)? It looks like it is to me, and I'm not sure how best to word the release notes.

Happy to release this, though - what do you think we should say in the release notes?

@gian1200
Copy link
Author

gian1200 commented Aug 27, 2025

In theory there is no breaking change for users. As explained in conventional-changelog/conventional-changelog#1308 (comment), this should not affect users using Node 16 or above (absolute-version already define Node 18 as the min version). However, for peace of mind, you could do a major bump to absolute-version instead of a minor, and mark it as a breaking change (up to you).

Unit testing was the only thing affected because Jest have the functionality behind an experiment flag (which I added in the script commands to solve it). After that, tests passed without issues.

Is this a breaking change for users who are using the API via jest

I'm not sure what you meant by "jest API", so I can't answer about it. Are users able to generate a release notes (change log) through jest 🤔?

@gian1200
Copy link
Author

what do you think we should say in the release notes?

Shouldn't it just say the same thing as any other dependency bump?

Something like

deps: update dependency conventional-changelog to v5.1,

or the same as the commit name

chore(deps): update conventional-changelog to v5.1.0.

Here is an example of the current changelog file:

### Bug Fixes
* **deps:** update dependency conventional-changelog to v4 ([#176](https://github.com/absolute-version/commit-and-tag-version/issues/176)) ([8d15fc7](https://github.com/absolute-version/commit-and-tag-version/commit/8d15fc788edc2fd5d901ccbbbacb3452eabc3091))
## [12.4.1](https://github.com/absolute-version/commit-and-tag-version/compare/v12.4.0...v12.4.1) (2024-04-28)

PS: I usually put dependencies updates as "chore", but it's ultimately up to you 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants