Pin Harbor timeout artifact recovery - #1194
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Oddish previewCommit:
Plan:
This comment is updated by the PR Preview workflow. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2eda5cb. Configure here.
| [tool.uv.sources] | ||
| # Keep the worker image on the exact Harbor revision used by Oddish's runtime gate. | ||
| harbor = { git = "https://github.com/abundant-ai/harbor", rev = "a7caa586de620f8a7103018f99ce9e1603f90eb4" } | ||
| harbor = { git = "https://github.com/abundant-ai/harbor", rev = "6e30ba35a5cfcf1fbd567a1f6b06fd69323e7e2c" } |
There was a problem hiding this comment.
Incomplete Harbor pin update
High Severity
Updating only the Oddish Harbor pin leaves HARBOR_DEFAULT_SHA and the backend pin/lock on a7caa586. Hosted workers bake Harbor from the backend source, so they still run the old revision and miss timeout artifact recovery. Existing lockstep guards expect all four pins to match.
Reviewed by Cursor Bugbot for commit 2eda5cb. Configure here.
There was a problem hiding this comment.
Risk: medium. Left a non-blocking comment — Cursor Bugbot finished as skipped and still has an unresolved high-severity finding on an incomplete Harbor pin update, so this is not approved. Assigning reviewers for human follow-up.
Sent by Cursor Approval Agent: Pull Request Router and Approver
2 participants
Summary
6e30ba35so hosted workers recover native ATIF-v1.7 fromclaude-code.txtafter agent deadline cancellationValidation
The separate zero-reward timeout path was proven end to end in Kind against the published PR #188 Slack candidate:
completion_reason=verifier_finalized_without_declaration,reward.jsonexists, and Harbor retains bothAgentTimeoutErrorandreward=0.0.Note
Medium Risk
Changes the Harbor runtime pin used by workers, which affects timeout handling and trial artifact recovery. Incorrect pinning could break trajectory recovery or timeout outcome behavior.
Overview
Pins the Harbor git dependency to
6e30ba35so hosted workers can recover native ATIF-v1.7 trajectories fromclaude-code.txtafter agent deadline cancellation.Updates
oddish/pyproject.tomland refreshesoddish/uv.lockto that exact revision.Reviewed by Cursor Bugbot for commit 4d4de79. Bugbot is set up for automated code reviews on this repo. Configure here.