Fix modular template to always generate class property syntax #1398
+1,740
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3db383c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Seems to be #1326 that introduced this |
smorimoto
force-pushed
the
feature/add-test-for-modular
branch
from
523369f to
22b4060
Compare
smorimoto
changed the title
The modular template was incorrectly using object method syntax (`:` and `,`) when route.namespace was present, introduced by PR acacode#1326. This caused TypeScript syntax errors in generated code. The modular template should always generate class properties with arrow functions (`=` and `;`), regardless of namespace presence. This resolves the issue reported in acacode#1366 where version 13.2.8 generated invalid TypeScript code with modular templates. Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
force-pushed
the
feature/add-test-for-modular
branch
from
22b4060 to
3db383c
Compare
|
@codex review |
Merged
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will reproduce the issues in #1366.
The snapshot is based on based on version 13.2.7.