Fix unneeded read in trace_parser
#189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `parse_from_string` method in `trace_parser.cc` currently reads in one delta for each active thread. However, `tracer_tool.cu` does not write the delta for the first thread since it will always be zero. This commit updates the behavior of `trace_parser` to match the intended trace format. Even though this bug was present, it had no effect in the past since the `base_delta_decompress` function is correct.
JRPan
requested review from
a team,
Shreya-gaur and
William-An
and removed request for
a team and
Shreya-gaur
|
@ammrat13 - thanks for the commit. @William-An, I am not sure we have all kinds of workloads with varying amounts of divergence in memory. However, the long tests are only looking at the uBenches which are probably almost always strided in their memory accesses. These look great - but it would be good to also correlate rodinia-3.1 I think so we get some more variety. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parse_from_stringmethod intrace_parser.cccurrently reads in one delta for each active thread. However,tracer_tool.cudoes not write the delta for the first thread since it will always be zero. This commit updates the behavior oftrace_parserto match the intended trace format.Even though this bug was present, it had no effect in the past since the
base_delta_decompressfunction is correct.