This repository was archived by the owner on Aug 16, 2023. It is now read-only.
test with starlette 0.15.0 on trio and asyncio (Sourcery refactored) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcery-ai
bot
force-pushed
the
sourcery/pull-8
branch
from
a91cc89 to
cec4579
Compare
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-78
to
+87
| try: | ||
| self.connection.quit() | ||
| except smtplib.SMTPServerDisconnected: | ||
| # This happens when calling quit() on a TLS connection | ||
| # sometimes, or when the connection was already disconnected | ||
| # by the server. | ||
| self.connection.close() | ||
| except smtplib.SMTPException: | ||
| if self.fail_silently: | ||
| return | ||
| raise | ||
| self.connection.quit() | ||
| except smtplib.SMTPServerDisconnected: | ||
| # This happens when calling quit() on a TLS connection | ||
| # sometimes, or when the connection was already disconnected | ||
| # by the server. | ||
| self.connection.close() | ||
| except smtplib.SMTPException: | ||
| if self.fail_silently: | ||
| return | ||
| raise |
Author
There was a problem hiding this comment.
Function EmailBackend.close refactored with the following changes:
- Merge nested try-statement into a single try (
flatten-nested-try)
Author
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.30%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 78.19% 77.84% -0.35%
==========================================
Files 14 14
Lines 509 510 +1
==========================================
- Hits 398 397 -1
- Misses 111 113 +2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #8 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!