refactor: add creator existence helper for shared checks#25
Merged
Chucks1093 merged 1 commit intoMar 26, 2026
Merged
Conversation
- Extract require_creator(env, creator) -> CreatorProfile helper to a
private impl block, replacing the duplicated inline storage lookup
- buy_key now uses Self::require_creator to validate creator registration,
keeping error message consistent ("creator not registered")
- All existing tests pass without modification
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14
require_creator(env: &Env, creator: &Address) -> CreatorProfilehelper into a dedicatedimpl CreatorKeysContractblockbuy_keynow callsSelf::require_creatorinstead of repeating the inline storage lookup + panic pattern"creator not registered"is unchanged, keeping existing tests and caller behaviour intactTest plan
test_buy_key_unregistered_creator_panics— still panics with expected message via helpertest_buy_key_insufficient_payment_panics— unaffected by refactortest_buy_key_sufficient_payment_succeeds— continues to passAll existing tests pass without modification.