feat: emit buy-key event with payment amount#26
Merged
Chucks1093 merged 5 commits intoMar 26, 2026
Merged
Conversation
- Update buy_key event data from `supply` to `(supply, payment)` tuple so indexers can observe the exact payment used in each transaction - Add tests verifying event data includes payment amount and that topics still carry the buy symbol, creator, and buyer addresses Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Reformat events().publish() call in buy_key to multi-line style - Sort use imports alphabetically in buy_key_event tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@JamesVictor-O Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@JamesVictor-O Fix the CI |
…y_key - Move balance_key update before event publish to avoid borrow-after-move - Remove duplicate event publish introduced during merge - Update test_buy_key_event_data_is_new_supply to expect (supply, payment) tuple
Contributor
Author
|
@Chucks1093 please review pr, Cl now passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #15
buy_keyevent data from a singlesupply: u32to a(supply, payment)tuple so indexers and off-chain consumers can observe the exact payment amount used in each transactionbuy, creator, buyer) remain unchangedTest plan
test_buy_key_event_includes_payment_amount— event data contains correct supply and payment valuestest_buy_key_event_topics_include_creator_and_buyer— topics still carrybuysymbol, creator, and buyer addresses