Add unit coverage for protocol config and supply reads#86
Merged
Chucks1093 merged 1 commit intoMar 28, 2026
Merged
Conversation
|
@davedumto Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds focused unit coverage for the internal read paths behind protocol config lookup and creator supply lookup.
The new tests stay scoped to helper and read behavior only:
0when the creator does not existImplementation Notes
The new unit tests were added in
creator-keys/src/test.rsand useenv.as_contract(...)so the helper functions are exercised in a valid contract-storage context.Snapshot fixtures generated for the new unit tests were included alongside the test changes.
Why This Matches The Issues
Testing
Closes #80
Closes #81
Closes #83
Closes #85