feat(creator-keys): emit richer registration events for indexing closes (#2)#9
Closed
edehvictor wants to merge 3 commits into
Closed
feat(creator-keys): emit richer registration events for indexing closes (#2)#9edehvictor wants to merge 3 commits into
edehvictor wants to merge 3 commits into
Conversation
Add dedicated CreatorRegistered event struct with creator, handle, supply, and ledger fields. Include creator address in event topic for downstream filtering. Add doc comments documenting the event schema and two tests verifying event emission and field values. closes accesslayerorg#2
|
@edehvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@edehvictor Fix merge conflict and CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dedicated CreatorRegistered event struct with creator, handle, supply, and ledger fields. Include creator address in event topic for downstream filtering. Add doc comments documenting the event schema and two tests verifying event emission and field values.
closes #2
Summary
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceChecklist