Skip to content

fix(creators): validate creator list include query values#97

Merged
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
shoaib050326:codex/issue-76-creator-include-parser
Mar 29, 2026
Merged

fix(creators): validate creator list include query values#97
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
shoaib050326:codex/issue-76-creator-include-parser

Conversation

@shoaib050326
Copy link
Copy Markdown

Summary

  • add a reusable parser for creator list include query values
  • wire include into the creator list query schema
  • reject unsupported include values instead of silently ignoring them

Root Cause

CreatorListQuerySchema did not declare an include field, so Zod stripped the query param entirely. That caused both valid and invalid include input to be ignored instead of validated.

Testing

  • node -r ts-node/register src/modules/creators/creators.include.parse.test.ts
  • node -r ts-node/register src/modules/creator/creator-list-page.guard.test.ts
  • node -r ts-node/register src/modules/creators/creator-list-item.mapper.test.ts
  • pnpm build

Closes #76

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Mar 29, 2026

@shoaib050326 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093 Chucks1093 merged commit c7e9ed2 into accesslayerorg:main Mar 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add creator list include parser

2 participants